Skip to content

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Oct 7, 2025

User description

🔗 Related Issues

Fixes #16390

💥 What does this PR do?

This PR adds a new GitHub Actions workflow jobs for Python: browser-tests-windows

This runs the Python integration tests on Windows/Chrome and Windows/Edge. The job is identical to the existing browser-tests job, but it includes the fsutil 8dot3name set 0 command to workaround the long path name issue that Bazel has on Windows.

Note: There's probably a better way to do this using a single matrix job where the command is only run when the runner is using Windows, but I couldn't figure that out.

💡 Additional Considerations

  • Unit tests on Windows are still not included because some tests randomly timeout on the GHA runners (can't reproduce locally)
  • Firefox on Windows is not included because it is insanely slow and would increase the job run time to 2+ hours

🔄 Types of changes

  • Build/Test

PR Type

Tests


Description

  • Add Windows CI job for browser tests

  • Include Windows path workaround with fsutil 8dot3name set 0

  • Support Chrome and Edge on Windows

  • Minor formatting improvements to existing commands


File Walkthrough

Relevant files
Tests
ci-python.yml
Add Windows CI jobs and formatting                                             

.github/workflows/ci-python.yml

  • Add browser-tests-windows job for Chrome, Edge
  • Include fsutil 8dot3name set 0 command for path issues
+56/-6   
Formatting
new_session_tests.py
Remove extra blank line                                                                   

py/test/unit/selenium/webdriver/remote/new_session_tests.py

  • Remove extra blank line after license header
+0/-1     
subtyping_tests.py
Remove extra blank line                                                                   

py/test/unit/selenium/webdriver/remote/subtyping_tests.py

  • Remove extra blank line after license header
+0/-1     

@selenium-ci selenium-ci added C-py Python Bindings B-build Includes scripting, bazel and CI integrations labels Oct 7, 2025
@cgoldberg cgoldberg force-pushed the py-readd-windows-ci-workflows branch from 6a25345 to f135738 Compare October 7, 2025 19:52
@SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Oct 7, 2025
@SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Oct 8, 2025
@cgoldberg cgoldberg self-assigned this Oct 8, 2025
@cgoldberg cgoldberg changed the title [py] Re-add Windows to CI workflows [py][build] Re-add Windows to CI workflows Oct 8, 2025
@cgoldberg cgoldberg merged commit 2e0159a into SeleniumHQ:trunk Oct 9, 2025
4 checks passed
@cgoldberg cgoldberg deleted the py-readd-windows-ci-workflows branch October 9, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-py Python Bindings Review effort 2/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: [py][build] Test errors when run with Bazel on Windows (long paths)

3 participants