[py][build] Re-add Windows to CI workflows #16396
Merged
+30
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
Fixes #16390
💥 What does this PR do?
This PR adds a new GitHub Actions workflow jobs for Python:
browser-tests-windows
This runs the Python integration tests on Windows/Chrome and Windows/Edge. The job is identical to the existing
browser-tests
job, but it includes thefsutil 8dot3name set 0
command to workaround the long path name issue that Bazel has on Windows.Note: There's probably a better way to do this using a single matrix job where the command is only run when the runner is using Windows, but I couldn't figure that out.
💡 Additional Considerations
🔄 Types of changes
PR Type
Tests
Description
Add Windows CI job for browser tests
Include Windows path workaround with
fsutil 8dot3name set 0
Support Chrome and Edge on Windows
Minor formatting improvements to existing commands
File Walkthrough
ci-python.yml
Add Windows CI jobs and formatting
.github/workflows/ci-python.yml
browser-tests-windows
job for Chrome, Edgefsutil 8dot3name set 0
command for path issuesnew_session_tests.py
Remove extra blank line
py/test/unit/selenium/webdriver/remote/new_session_tests.py
subtyping_tests.py
Remove extra blank line
py/test/unit/selenium/webdriver/remote/subtyping_tests.py